Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI via GitHub actions #159

Closed
ccoVeille opened this issue Jun 7, 2024 · 1 comment · Fixed by #160
Closed

Add a CI via GitHub actions #159

ccoVeille opened this issue Jun 7, 2024 · 1 comment · Fixed by #160
Labels
enhancement New feature or request

Comments

@ccoVeille
Copy link
Contributor

ccoVeille commented Jun 7, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
I pushed changes with #158 and I forgot to launch the tests
There was no CI to catch it.

We shouldn't be able to push code that could be merged without being tested.

Describe the solution you'd like
please add a GitHub action to launch the test to validate incoming PRs
@ccoVeille ccoVeille added the enhancement New feature or request label Jun 7, 2024
@shoenig
Copy link
Owner

shoenig commented Jun 7, 2024

Ah, we do already have https://github.com/shoenig/test/blob/main/.github/workflows/ci.yaml
but it's configured to run on push - it should also be configured to run on pull_request.

@shoenig shoenig mentioned this issue Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run on pull_request shoenig/test
2 participants
@shoenig @ccoVeille