Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo function #113

Open
shnupta opened this issue Mar 5, 2018 · 11 comments
Open

Undo function #113

shnupta opened this issue Mar 5, 2018 · 11 comments

Comments

@shnupta
Copy link
Owner

shnupta commented Mar 5, 2018

Allow the previous few operations to be undone by the user.

Current undo needs:

  • Should bind to ctrl-z in insert mode
  • Should bind to ctrl-z and u in normal mode
  • Should be able to undo at least the last 25 operations.
  • Ctrl-r for redo. (undo the last undo)
@anfly0
Copy link
Contributor

anfly0 commented Mar 6, 2018

I think that it would be a good idea to flesh out some more details about this feature.
If nothing else, we can get a discussion going!

I'll start:

  • Should bind to ctrl-z in insert mode
  • Should bind to ctrl-z and u in normal mode
  • Should be able to undo at least the last 25 operations.

@shnupta
Copy link
Owner Author

shnupta commented Mar 6, 2018

@anfly0

Nice suggestions. I'll also add:

  • Ctrl-r for redo. (undo the last undo)

@HeyAEE
Copy link

HeyAEE commented Mar 7, 2018

I'd like to try working on this as my first OSS contribution!

@anfly0
Copy link
Contributor

anfly0 commented Mar 7, 2018

@HeyAEE I don't think there is anyone else working on this, so there would be no harm in trying!
Just to satisfy my curiosity, what are your thoughts about how to implement this?
If you are up for it I would be happy to help!

@shnupta
Copy link
Owner Author

shnupta commented Mar 25, 2018

@HeyAEE any progress on this?

@dblnz
Copy link

dblnz commented Sep 20, 2018

If there's nobody working on this I would like to give it a try.

@andy5995
Copy link
Contributor

How's it coming along, @BlanzeanuDoru ?

@dblnz
Copy link

dblnz commented Sep 27, 2018

I Haven’t started yet, wanted to see whether anybody is currently working on this

@andy5995
Copy link
Contributor

Oh, I see. No one has said they were working on it in 6 months, so feel free. :) I think a linked list would be the way to go, but I haven't ever done anything like this before. Have ideas on how you'd start, @BlanzeanuDoru

@dblnz
Copy link

dblnz commented Sep 27, 2018

I haven't got the chance to look over the code very thoroughly, I'll do that in the weekend, I have a very tight schedule this week. I'll comment with what my solution is before starting to implement,

@andy5995
Copy link
Contributor

andy5995 commented Oct 8, 2018

I'll open this ticket for others to work on now. Anyone interested please leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants