Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Common module #443

Closed
4 tasks done
acelaya opened this issue Aug 7, 2019 · 0 comments · Fixed by #459
Closed
4 tasks done

Restructure Common module #443

acelaya opened this issue Aug 7, 2019 · 0 comments · Fixed by #459
Assignees
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Aug 7, 2019

Rearrange Common module, splitting its content based on this criteria:

First two can be sent to separated composer libraries (shlinkio/shlink-common -> Shlinkio\Shlink\Common and shlinkio/shlink-ip-geolocation -> Shlinkio\Shlink\IpGeolocation)

The third one could also be a package of its own which shlink uses as a dev dependency.

Last one could be kept inside the main shlink project with different name and namespace (maybe Shlinkio\Shlink\PreviewGenerator?) and marked as deprecated to ease removing it for v2.

@acelaya acelaya added this to the 1.19.0 milestone Aug 7, 2019
@acelaya acelaya modified the milestones: 1.19.0, 1.18.1 Aug 7, 2019
@acelaya acelaya self-assigned this Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant