Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture errors in CloseDbConnectionMiddleware #427

Closed
acelaya opened this issue Jul 31, 2019 · 0 comments · Fixed by #431
Closed

Capture errors in CloseDbConnectionMiddleware #427

acelaya opened this issue Jul 31, 2019 · 0 comments · Fixed by #431
Assignees
@acelaya
Labels
bug
Milestone
1.18.0

Comments

@acelaya
Copy link
Member

acelaya commented Jul 31, 2019

Capture any exception to make sure connection gets closed before rethrowing it.

Reported first at #423
@acelaya acelaya added the bug label Jul 31, 2019
@acelaya acelaya added this to the 1.18.0 milestone Jul 31, 2019
@acelaya acelaya self-assigned this Jul 31, 2019
@acelaya acelaya mentioned this issue Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acelaya acelaya

Labels
bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

Feature/close db on error acelaya-forks/shlink
1 participant
@acelaya