-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it expected behaviour that Shlink will delete any and all keys in the Redis server? #1580
Comments
No, that's not the expected behavior. There's no reason for Shlink to do that. I will check it. |
I think this might be a bug. I attached the log from redis-cli monitor after starting/restarting shlink instance. Check line 95: ("1670580633.643543 [0 172.27.0.6:40652] "FLUSHDB") redis-monitor-shlink-start.log My set-up (all applications run as docker containers):
|
Wow, I would not expect that to happen. I wonder if this is the culprit. Need to check further what does that command actually do |
Ok, yes, the command above does run a FLUSHDB when configured cache is redis and there's no cache namespace configured. Apparently the cache namespace was accidentally removed from Shlink at some point. I will get it back to fix this. |
I have just merged the fix for this. It will be included with Shlink 3.4.0 |
How Shlink is set-up
Summary
Is it the expected behaviour, or is it a bug, that Shlink when configured to use Redis will delete ALL the Keys in Redis even ones it did not create?
In other words any existing Keys in Redis get deleted by Shlink almost immediately after starting up.
I could not find anything in the docs indicating that this would occur.
If this is the intended behaviour it might be nice to point this out in the docs lest someone find out the hard way!
The text was updated successfully, but these errors were encountered: