Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for the default domain does not return any results in the short URL list #1519

Closed
bildschirmartist opened this issue Aug 22, 2022 · 2 comments · Fixed by #1621
Closed

Comments

@bildschirmartist
Copy link

Shlink web client version

  • Version: 3.7.2
  • How do you use shlink-web-client: Docker image

Summary

The list of short urls cannot be filtered by default domain using search.

Current behavior

Currently I run shlink with one shlink container and several domains. When I now search for links to the default domain in the short URL list, I unfortunately get no results. For all other domains the search works fine in this respect.

Expected behavior

Wenn ich in der Suche die Default Domain eingebe, sollten auch sämtliche Short URLs der Default Domain aufgelistet sein

How to reproduce

Setup the following:
  • Default Domain: shlink.dev
  • Other Domains: shlink01.dev, shlink02.dev
  • Create short links for each of the specified domains.

Afterwards: If you enter "shlink01.dev" or "shlink02.dev" in the search bar, you get the Short URL list filtered accordingly. On the other hand, if you type "shlink.dev", no short URLs are displayed in the list.

@acelaya acelaya transferred this issue from shlinkio/shlink-web-client Aug 23, 2022
@acelaya
Copy link
Member

acelaya commented Aug 23, 2022

Yes, this is a known limitation.

The reason for this is that the default domain is not actually saved in the database. URLs linked to the default domain are actually not linked to anything (for historical reasons, and to keep compatibility when multi-domain support was introduced).

This makes search queries not possible for the default domain.

I have considered a couple of workarounds for this, but I'm not sure how effective would they be. I have to test a bit.

A possible workaround would be to add an explicit filtering option based on the domain, in the same way that happens with tags. That would make it easier to translate "default domain" into "no domain".

@acelaya acelaya added this to the 3.4.0 milestone Sep 17, 2022
@acelaya acelaya added this to Shlink Sep 25, 2022
@acelaya acelaya moved this to Todo 🗒️ in Shlink Sep 25, 2022
@acelaya acelaya removed the status in Shlink Sep 25, 2022
@acelaya acelaya moved this to Todo 🗒️ in Shlink Dec 3, 2022
@acelaya acelaya moved this from Todo 🗒️ to In Progress 📝 in Shlink Dec 7, 2022
@acelaya
Copy link
Member

acelaya commented Dec 8, 2022

I have managed to find a way to make search work when introducing the default domain, without needing to add a new filtering option which would make things more complicated.

@acelaya acelaya moved this from In Progress 📝 to In review 👀 in Shlink Dec 8, 2022
Repository owner moved this from In review 👀 to Done ✅ in Shlink Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants