Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expressive 2.2 causes failures by triggering E_USER_DEPRECATED errors #126

Closed
2 of 3 tasks
weirdan opened this issue Mar 20, 2018 · 2 comments
Closed
2 of 3 tasks
Assignees
Labels
Milestone

Comments

@weirdan
Copy link
Contributor

weirdan commented Mar 20, 2018

Since Zend Expressive 2.2 (which is transitional release to get people prepared for Expressive 3.0) if error_reporting includes E_USER_DEPRECATED (and it's set to E_ALL, which does, at least in development mode), shlink will fail some tests and all http requests. Shlink allows any 2.* version of Zend Expressive, including 2.2. You can trigger a build on travis to see test failures for yourself.

There are several options:

  • Tighten version constraints to forbid Expressive 2.2 from being used with Shlink (going to submit PR for that soon)
  • Fix the code and do not use deprecated functionality. See Upgrading to 2.2 guide
  • Upgrade to Expressive 3.0 (includes point 2). See Upgrading to 3.0 guide
@acelaya
Copy link
Member

acelaya commented Mar 21, 2018

I see you have created two pull requests. I appreciate that :)

Let me take a look at them later today. I'll merge one of them.

Also, I plan to update to expressive 3 in the next days, but there's one dependency which needs to be checked first.

@acelaya acelaya added this to the 1.7.1 milestone Mar 21, 2018
@acelaya acelaya added the bug label Mar 21, 2018
@acelaya
Copy link
Member

acelaya commented Mar 21, 2018

Closed via #128

@acelaya acelaya closed this as completed Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants