Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency in swoole/openswoole extension for some options #199

Closed
acelaya opened this issue Nov 11, 2023 · 0 comments · Fixed by #204
Closed

Remove dependency in swoole/openswoole extension for some options #199

acelaya opened this issue Nov 11, 2023 · 0 comments · Fixed by #204
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Nov 11, 2023

Some of the options are skipped if swoole extension is not detected. This is because, traditionally, they were relevant only for real-time updates, which used to require swoole.

Some versions ago, Shlink started to support roadrunner, which also supports real time updates. Someone trying to run Shlink with roadrunner and configured via installer tool would not get asked about some relevant questions.

Make those options stop depending on the presence of swoole/openswoole extension, and instead ask at the beginning how is Shlink going to be served, adjusting the questions accordingly.

@acelaya acelaya added this to Shlink Nov 11, 2023
@acelaya acelaya added this to the 8.6 milestone Nov 11, 2023
@acelaya acelaya moved this to Todo in Shlink Nov 11, 2023
@acelaya acelaya changed the title Remove dependency on swoole for some options Remove dependency in swoole/openswoole extension for some options Nov 11, 2023
@acelaya acelaya moved this from Todo to In Progress in Shlink Nov 23, 2023
@acelaya acelaya moved this from In Progress to In review in Shlink Nov 25, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant