Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_read_attribute in ActiveRecord should be public #149

Closed
shioyama opened this issue Dec 24, 2017 · 0 comments
Closed

_read_attribute in ActiveRecord should be public #149

shioyama opened this issue Dec 24, 2017 · 0 comments
Labels
active_record active_record_5.2 dirty_plugin

Comments

@shioyama
Copy link
Owner

Tests in Spina are failing with an error that _read_attribute is private. The issue is that as of #116 Mobility overrides _read_attribute in the Dirty plugin, but this override sets the method to be private, when in fact although it is private in ActiveModel, it is public in ActiveRecord. So it should be public in the AR Dirty plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
active_record active_record_5.2 dirty_plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shioyama