Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with KDE Wallet Manager (KWallet) #940

Open
Beanazril opened this issue Oct 11, 2023 · 3 comments
Open

Incompatibility with KDE Wallet Manager (KWallet) #940

Beanazril opened this issue Oct 11, 2023 · 3 comments

Comments

@Beanazril
Copy link

The feature request

GitHub Desktop works by default with gnome-keyring, and installs it and uses it even on devices already using kdewallet and KWallet by default.

Proposed solution

Github Desktop should either:

  • Create and use a default keyring in kdewallet instead if it is already the default keyring manager
    OR
  • Communicate clearly to the user the "Default keyring" used by GitHub Desktop is on gnome-keyring and accessible with "Passwords and Keys" (seahorse) and not KWallet. seahorse should also be added as a dependency in that case.

Additional context

I'm using Ubuntu 22.04 and had great difficulty what was wrong with my keyrings. I had only KWalletManager to open my keyrings, and this didn't show me the "Default keyring" GitHub Desktop was using on gnome-keyring. By all means the "Default keyring" was inivisble. I had to realise that GitHub Desktop installed gnome-keyring and was using this instead of kdewallet, then install seahorse, then delete the "Default keyring" beacause I didn't know the password for it. This was very frustrating and to my understanding, it should be what happens normally to KDE users who never used gnome-keyring.

@shiftkey
Copy link
Owner

Create and use a default keyring in kdewallet instead if it is already the default keyring manager

We use libsecret for interacting with the credential store, with gnome-keyring having supported that for years it became our default. I'd happily use KWallet if that supports libsecret and it seems to have landed earlier this year #759 (comment)

I'm not sure when I'll have time to setup a KDE machine and test this support but if this seems to work then I'm open to figuring out how to express "either gnome-keying or kwallet" in the packaging dependencies.

@hazel-bunny
Copy link

I would like to fix this issue, but I'm unable to find the rpm spec file. Basically I need to add something like Requires: (gnome-keyring if gnome-shell) and Requires: (kf6-kwallet if plasma-desktop)

@mkurz
Copy link

mkurz commented Dec 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants