Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to complete authentication doing browser flow - --enable-crashpad received #677

Closed
laercio-carvalho opened this issue Mar 18, 2022 · 22 comments
Labels
retest-requested Issue needs to be verified against latest version of app

Comments

@laercio-carvalho
Copy link

Describe the feature or problem you’d like to solve

I can't sign in with browser.
I'm trying to do login in the browser but it never finish.
image

Proposed solution

To have a "sign in" on the GitHub Desktop again.
image

PS: I'm try to talk in english but my native language is Portuguese.

@laercio-carvalho
Copy link
Author

Describe the feature or problem you’d like to solve

I can't sign in with browser. I'm trying to do login in the browser but it never finish. image

Proposed solution

To have a "sign in" on the GitHub Desktop again. image

PS: I'm try to talk in english but my native language is Portuguese.

Temporarily I solved my problem using 2.9.6

@BrahimDahmani
Copy link

BrahimDahmani commented Mar 18, 2022

+1

@bronnel
Copy link

bronnel commented Mar 19, 2022

I have the same issue

@vinicioslc
Copy link

vinicioslc commented Mar 20, 2022

I have the same issue ElementaryOS
Apparently something with url from deeplinking url
image
The function that receives the oauth action its receiving unknown instead oauth with data
image

Version used its flatpak most recent
[AppStore] loading 0 repositories from store
install.ts:28 launching: 2.9.9-linux2 (Linux 5.13.0-35-generic)

@owocado
Copy link

owocado commented Mar 20, 2022

I also have the same issue on latest version. I checked dev console and seeing the same warning message posted by @vinicioslc above. I installed through yay/pacman (bin version).

@miracleflame
Copy link

miracleflame commented Mar 22, 2022

+1 on fresh Linux Mint

@guipaulo
Copy link

+1 i have the same issue

@nahuel3pro
Copy link

+1 on manjaro

@LarveyOfficial
Copy link

+1 popOS

@WilPermenter
Copy link

WilPermenter commented Mar 23, 2022

+1

Edit: This is a known issue. The best fix for this is to install an old version 2.9.6> and sign in on it. Once that is done then Login on that and then you can install the newer version. This Solution works on Ubuntu & Arch and probably everything else.

@pegvin
Copy link

pegvin commented Mar 25, 2022

Same issue with me:

OS: Manjaro Linux
Linux Version 5.15
GitHub Desktop Version: 2.9.9-linux2
Architecture: x64

My Log File:

2022-03-25T06:59:15.600Z - info: [ui] [AppStore] loading 0 repositories from store
2022-03-25T06:59:15.707Z - info: [ui] launching: 2.9.9-linux2 (Linux 5.15.28-1-MANJARO)
2022-03-25T06:59:15.707Z - info: [ui] execPath: '/opt/github-desktop/github-desktop'
2022-03-25T06:59:20.021Z - info: [ui] [SignInStore] initializing OAuth flow
2022-03-25T06:59:20.024Z - info: [main] opening in browser: https://github.com/login/oauth/authorize?client_id=ID-HIDDEN-BECAUSE-NOT-SURE-IF-ITS-SAFE-TO-SHARE
2022-03-25T06:59:22.746Z - info: [main] Received possible protocol arguments: 4
2022-03-25T06:59:22.746Z - info: [main] Processing protocol url
2022-03-25T06:59:22.748Z - warn: [ui] Unknown URL action: unknown - payload: {"name":"unknown","url":"--enable-crashpad"}

@K0-RR K0-RR mentioned this issue Mar 25, 2022
@mattheusts
Copy link

+1 Archlinux using the version provided by aur 2.9.9-2.

@pegvin
Copy link

pegvin commented Mar 28, 2022

I downgraded my version to 2.9.4 and it works currently!

@shiftkey
Copy link
Owner

shiftkey commented Apr 3, 2022

Apologies for the delay in digging into this - I've had many other things distracting me. I recommend downgrading in the meantime to an earlier version, as those should be unaffected.

I've dusted off my test machine and walked through the steps here and I see this --enable-breakpad message when I do the sign-in flow, so clearly something's broken here with how the app is being re-launched with the 2.9.9 update.

@shiftkey
Copy link
Owner

shiftkey commented Apr 3, 2022

My working theory on this bug is the Electron upgrade has changed what parameters are passed through. After tracing what URL is received within the app I see a number of parameters preceding the URL parameter that we need:

handlePossibleProtocolLauncherArgs: ["github-desktop","--enable-crashpad","--allow-file-access-from-files","x-github-desktop-dev-auth://oauth?code=[snip]&state=[snip]"]

What we do currently is just pass in the item at index 1, which appears to be this line:

} else if (args.length > 1) {
handleAppURL(args[1])
}

@shiftkey
Copy link
Owner

shiftkey commented Apr 3, 2022

I've backported the bugfix from #687 to the release where this was first noticed, if you want to verify this addresses the issue we were originally seeing:

Otherwise this is available in the latest release that contains all the upstream changes:

I'll leave this open for a while to confirm this has resolved the problem for users, but if you're seeing different behaviour let's move this to a fresh issue due to the noise.

@shiftkey shiftkey added the retest-requested Issue needs to be verified against latest version of app label Apr 3, 2022
@shiftkey
Copy link
Owner

shiftkey commented Apr 3, 2022

@thyeun has informed me that #687 doesn't cover the cases completely, and was seeing this with the latest release:

2022-04-03T18:15:34.707Z - warn: [ui] Unknown URL action: unknown - payload: {"name":"unknown","url":"/usr/bin/github-desktop"}

I think #689 will also handle that case. Will drop a link to the new installer when it's ready.

@shiftkey
Copy link
Owner

shiftkey commented Apr 3, 2022

2.9.12 Linux RC3 is available for testing which has an additional fix

@SpriteOvO
Copy link

@shiftkey I successfully logged in on 2.9.12 Linux RC3, but not RC2. Thank you very much!

@joaoKuchnir
Copy link

Fixed for me in manjaro, thanks!

@mwt
Copy link

mwt commented Apr 3, 2022

RC3 works for me on Ubuntu Focal.

@shiftkey shiftkey changed the title Can't Sign in Unable to complete authentication doing browser flow - --enable-crashpad received Apr 3, 2022
@shiftkey
Copy link
Owner

shiftkey commented Apr 4, 2022

Closing this out as resolved

@shiftkey shiftkey closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
retest-requested Issue needs to be verified against latest version of app
Projects
None yet
Development

No branches or pull requests