Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 3.4.13 release #1194

Closed
shiftkey opened this issue Feb 5, 2025 · 3 comments
Closed

Publish 3.4.13 release #1194

shiftkey opened this issue Feb 5, 2025 · 3 comments
Assignees

Comments

@shiftkey
Copy link
Owner

shiftkey commented Feb 5, 2025

No description provided.

@shiftkey
Copy link
Owner Author

shiftkey commented Feb 9, 2025

This is on hold while I understand the test failures in the bundled git - if it's tied to a newer glibc that might break consumers:


Done in 1.94s.
yarn run v1.21.1
$ cross-env ELECTRON_RUN_AS_NODE=1 NODE_OPTIONS='--max_old_space_size=4096' ./node_modules/.bin/electron ./node_modules/jest/bin/jest --detectOpenHandles --silent --testLocationInResults --config ./app/jest.unit.config.js
FAIL app/test/unit/git/commit-test.ts (18.55 s)
  ● git/commit › createCommit normal › commits the given files

    GitError: /github/workspace/app/node_modules/dugite/git/bin/git: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /github/workspace/app/node_modules/dugite/git/bin/git)

      332 |       log.error(errorMessage.join('\n'))
      333 |
    > 334 |       throw new GitError(gitResult, args, terminalOutput)
          |             ^
      335 |     },
      336 |     path,
      337 |     options?.isBackgroundTask ?? false,

      at src/lib/git/core.ts:334:13
      at src/lib/trampoline/trampoline-environment.ts:124:14
      at withTrampolineToken (src/lib/trampoline/trampoline-tokens.ts:33:14)
      at getStatus (src/lib/git/status.ts:203:32)
      at getStatusOrThrow (test/helpers/status.ts:10:17)
      at Object.<anonymous> (test/unit/git/commit-test.ts:60:20)

@shiftkey
Copy link
Owner Author

shiftkey commented Feb 9, 2025

Probably related to desktop/dugite-native#513

@shiftkey
Copy link
Owner Author

shiftkey commented Feb 9, 2025

@shiftkey shiftkey closed this as completed Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant