Skip to content

Commit 7877b59

Browse files
authored
chore: change supported node versions (#186)
This adds testing for node v11 - v14. This removes testing for node v6 and v7 because codecov breaks on these versions. This omits node v15 because appveyor doesn't seem to support this version. The nodejs org currently supports [10, 12, 14, 15]. This adds a small logging statement to the check-node-support script. Test: npm run check-node-support
1 parent 43516c2 commit 7877b59

File tree

5 files changed

+14
-8
lines changed

5 files changed

+14
-8
lines changed

.travis.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
language: node_js
22
sudo: false
33
node_js:
4-
- 6
5-
- 7
64
- 8
75
- 9
86
- 10
7+
- 11
8+
- 12
9+
- 13
10+
- 14
911

1012
os:
1113
- linux

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
commands, providing an easy solution for simple Unix-like, cross-platform
1111
commands in npm package scripts.
1212

13-
`shx` is proudly tested on every node release since <!-- start minVersion -->`v6`<!-- stop minVersion -->!
13+
`shx` is proudly tested on every node release since <!-- start minVersion -->`v8`<!-- stop minVersion -->!
1414

1515
## Difference Between ShellJS and shx
1616

appveyor.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
environment:
22
matrix:
3+
- nodejs_version: '14'
4+
- nodejs_version: '13'
5+
- nodejs_version: '12'
6+
- nodejs_version: '11'
37
- nodejs_version: '10'
48
- nodejs_version: '9'
59
- nodejs_version: '8'
6-
- nodejs_version: '7'
7-
- nodejs_version: '6'
810

911
version: '{build}'
1012

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,6 @@
7575
"shelljs": "^0.8.4"
7676
},
7777
"engines": {
78-
"node": ">=6"
78+
"node": ">=8"
7979
}
8080
}

scripts/check-node-support.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ var yaml = require('js-yaml');
88
var shell = require('shelljs');
99

1010
// This is the authoritative list of supported node versions.
11-
var MIN_NODE_VERSION = 6;
12-
var MAX_NODE_VERSION = 10;
11+
var MIN_NODE_VERSION = 8;
12+
var MAX_NODE_VERSION = 14;
1313

1414
function checkReadme(minNodeVersion) {
1515
var start = '<!-- start minVersion -->';
@@ -78,6 +78,8 @@ try {
7878
var appveyorFileName = path.join(__dirname, '..', 'appveyor.yml');
7979
var appveyorYaml = yaml.safeLoad(shell.cat(appveyorFileName));
8080
checkAppveyor(MIN_NODE_VERSION, MAX_NODE_VERSION, appveyorYaml);
81+
console.log('All files look good (this project supports v'
82+
+ MIN_NODE_VERSION + '-v' + MAX_NODE_VERSION + ')!');
8183
} catch (e) {
8284
console.error('Please check the files which declare our Node version');
8385
console.error('support, as something is out-of-sync. This script failed');

0 commit comments

Comments
 (0)