Upgrade eslint & related packages #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theclive
commented
Mar 29, 2021
| Prettier-standard includes following packages so you don't need to install them in your repository: | ||
|
|
||
| - eslint | ||
| - babel-eslint | ||
| - @babel/eslint-parser |
There was a problem hiding this comment.
babel-eslint was deprecated 6 months ago
Comment on lines
+125
to
+127
| parserOptions: { | ||
| requireConfigFile: false | ||
| }, |
There was a problem hiding this comment.
This solves the babel parsing error that throws for each file after upgrading to @babel/eslint-parser:
./prettier-standard/src/cli.js
0:0 error Parsing error: No Babel config file detected for ./prettier-standard/src/cli.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files
./prettier-standard/src/index.js
0:0 error Parsing error: No Babel config file detected for ./prettier-standard/src/index.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files
./prettier-standard/src/scms/git.js
0:0 error Parsing error: No Babel config file detected for ./prettier-standard/src/scms/git.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files
./prettier-standard/src/utils.js
0:0 error Parsing error: No Babel config file detected for ./prettier-standard/src/utils.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files
./prettier-standard/test/cli.test.js
0:0 error Parsing error: No Babel config file detected for ./prettier-standard/test/cli.test.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files
./prettier-standard/test/index.test.js
0:0 error Parsing error: No Babel config file detected for ./prettier-standard/test/index.test.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files
Comment on lines
-134
to
-141
| getConfig('prettier', 'index.js'), | ||
| getConfig('prettier', '@typescript-eslint.js'), | ||
| getConfig('prettier', 'babel.js'), | ||
| getConfig('prettier', 'flowtype.js'), | ||
| getConfig('prettier', 'react.js'), | ||
| getConfig('prettier', 'standard.js'), | ||
| getConfig('prettier', 'unicorn.js'), | ||
| getConfig('prettier', 'vue.js') |
There was a problem hiding this comment.
This addresses the breaking changes from v8.0.0 of eslint-config-prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes #114 by updating eslint and related packages to the latest versions.