Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian archive is missing vendor completions. #554

Closed
eth-p opened this issue May 2, 2019 · 9 comments
Closed

Debian archive is missing vendor completions. #554

eth-p opened this issue May 2, 2019 · 9 comments
Labels
help wanted Extra attention is needed packaging/tooling

Comments

@eth-p
Copy link
Collaborator

eth-p commented May 2, 2019

The amd64 .deb archive (and probably others) under the releases page is missing vendor-provided shell autocompletions.

Here are the paths that I could find:

Bash: /usr/share/bash-completion/completions/
The completion script should have no file extension.

Fish: /usr/share/fish/vendor_completions.d/
The completion script should end in .fish.

Zsh: /usr/share/zsh/vendor-completions/
The completion filenames seem to all begin with an underscore. I'm not familiar with zsh though, so I could be wrong. It also seems like they shouldn't have a file extension.

It's also important to note that some of these may be located at /usr/local/share/..., depending on whether or not the distro packages use /usr/local or /usr as the default prefix. Maybe some kind of install script could be added that copies it to the correct location, depending on whether or not the /usr/local/share/... folder exists?

@eth-p eth-p changed the title Debian archive missing vendor completions. Debian archive is missing vendor completions. May 2, 2019
@sharkdp
Copy link
Owner

sharkdp commented May 2, 2019

Please check out the release notes (https://github.com/sharkdp/bat/releases):

Manual fish completion files were recently re-enabled in #524. There has been no release since then.

@eth-p
Copy link
Collaborator Author

eth-p commented May 3, 2019

Ah, that explains it. My bad!

@eth-p eth-p closed this as completed May 3, 2019
@yogan
Copy link

yogan commented May 17, 2019

I'm confused about the situation with the recent release of v0.11.0. The release notes state that now completions for fish are included (which would be great!), but the .deb does not contain any .fish file. Am I missing something here? Do they have to be generated somehow?

@eth-p
Copy link
Collaborator Author

eth-p commented May 17, 2019

Reopening, since the Debian archives for v0.11.0 still don't contain vendor completions.

@eth-p eth-p reopened this May 17, 2019
@sharkdp
Copy link
Owner

sharkdp commented May 18, 2019

I think my comment above was incomplete in the sense that the DEB packages on the Release page apparently never included the completion files (I can't find anything in the Git log).

We do ship autocompletion files (currently only fish) in the tarballs, so some distributions did also include them in the respective packages in the past.

If somebody wants to fix this for the automatically deployed DEB packages, I'm happy to create a new release. The place would be the make_deb function in ci/before_deploy.sh. The actual fix will probably be simple but I would appreciate some research into this topic. I don't want the DEB package to be "broken" somehow (for some distributions?). I would also like to make sure that the deployment process is kept simple and reliable. Making new releases is a lot of work already.

@sharkdp
Copy link
Owner

sharkdp commented Aug 15, 2019

Does somebody know where would have to install the fish completion file?

@sharkdp
Copy link
Owner

sharkdp commented Aug 15, 2019

Probably under /usr/share/fish/completions/bat.fish, like we do for fd:

https://github.com/sharkdp/fd/blob/040c57e007ee49874e47a7fffa74d7d69178b6a1/ci/before_deploy.bash#L147

(batfish is actually an animal that exists)

@sharkdp
Copy link
Owner

sharkdp commented Aug 28, 2019

should be included in the next release

@sharkdp
Copy link
Owner

sharkdp commented Aug 31, 2019

Fish completions are included in the Debian packages for bat v0.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed packaging/tooling
Projects
None yet
Development

No branches or pull requests

3 participants