Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable use of italics (by default) #389

Closed
sharkdp opened this issue Oct 31, 2018 · 4 comments
Closed

Disable use of italics (by default) #389

sharkdp opened this issue Oct 31, 2018 · 4 comments
Labels
feature-request New feature or request good first issue Good for newcomers
Milestone
0.9.0

Comments

@sharkdp
Copy link
Owner

sharkdp commented Oct 31, 2018

Disable the use of ANSI-italics by default, but add a new option --enable-italics that users can put in their config file, if they want to opt-in.

Rationale:
@sharkdp sharkdp added feature-request New feature or request good first issue Good for newcomers labels Oct 31, 2018
@Ashniu123
Copy link
Contributor

Ashniu123 commented Oct 31, 2018 •
edited
Loading

I'll take this.

Could you please guide me through to which files should I look to make changes to?

@Ashniu123 Ashniu123 mentioned this issue Oct 31, 2018
Merged
@sharkdp sharkdp added this to the 0.9.0 milestone Nov 1, 2018
@chaucerbao
Copy link

It looks like #96 was the PR that added font styles.

@sharkdp
Copy link
Owner Author

sharkdp commented Nov 4, 2018

Closed via #390 by @Ashniu123.

@sharkdp sharkdp closed this as completed Nov 4, 2018
@sharkdp
Copy link
Owner Author

sharkdp commented Nov 11, 2018

This is now available in bat 0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
3 participants
@chaucerbao @sharkdp @Ashniu123