From 5c76c4c4e0199144dc3621dbe423d2c3e3914635 Mon Sep 17 00:00:00 2001 From: gomes <17035424+gomesalexandre@users.noreply.github.com> Date: Thu, 20 Feb 2025 19:31:58 +0100 Subject: [PATCH 1/2] feat: only show rate changed on unfavorable change --- .../MultiHopTrade/components/SharedConfirm/AssetSummaryStep.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/MultiHopTrade/components/SharedConfirm/AssetSummaryStep.tsx b/src/components/MultiHopTrade/components/SharedConfirm/AssetSummaryStep.tsx index 653786be2e8..1d7613b2858 100644 --- a/src/components/MultiHopTrade/components/SharedConfirm/AssetSummaryStep.tsx +++ b/src/components/MultiHopTrade/components/SharedConfirm/AssetSummaryStep.tsx @@ -76,7 +76,7 @@ export const AssetSummaryStep = ({ ) ) return - if (amountCryptoBaseUnit === prevAmountCryptoBaseUnit) return + if (bn(amountCryptoBaseUnit).gte(prevAmountCryptoBaseUnit)) return rateChanged.open({ prevAmountCryptoBaseUnit }) }, [amountCryptoBaseUnit, isLastStep, prevAmountCryptoBaseUnit, rateChanged]) From 02866cac02c2c7e6ccd613b18bcd93c798394f5f Mon Sep 17 00:00:00 2001 From: gomes <17035424+gomesalexandre@users.noreply.github.com> Date: Thu, 20 Feb 2025 21:06:12 +0100 Subject: [PATCH 2/2] feat: tackle everywhere --- .../TradeConfirm/components/ExpandedStepperSteps.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/MultiHopTrade/components/TradeConfirm/components/ExpandedStepperSteps.tsx b/src/components/MultiHopTrade/components/TradeConfirm/components/ExpandedStepperSteps.tsx index 0c81cb0ee58..30a54e19be4 100644 --- a/src/components/MultiHopTrade/components/TradeConfirm/components/ExpandedStepperSteps.tsx +++ b/src/components/MultiHopTrade/components/TradeConfirm/components/ExpandedStepperSteps.tsx @@ -19,6 +19,7 @@ import { CircularProgress } from 'components/CircularProgress/CircularProgress' import { RawText, Text } from 'components/Text' import { getChainAdapterManager } from 'context/PluginProvider/chainAdapterSingleton' import { useModal } from 'hooks/useModal/useModal' +import { bn } from 'lib/bignumber/bignumber' import { selectFirstHopSellAccountId, selectSecondHopSellAccountId, @@ -195,7 +196,7 @@ export const ExpandedStepperSteps = ({ activeTradeQuote }: ExpandedStepperStepsP ) ) return - if (firstHopAmountCryptoBaseUnit === prevFirstHopAmountCryptoBaseUnit) return + if (bn(firstHopAmountCryptoBaseUnit).gte(prevFirstHopAmountCryptoBaseUnit)) return rateChanged.open({ prevAmountCryptoBaseUnit: prevFirstHopAmountCryptoBaseUnit }) }, [