Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warnings #965

Closed
robwise opened this issue Oct 27, 2017 · 3 comments
Closed

Deprecation Warnings #965

robwise opened this issue Oct 27, 2017 · 3 comments
Assignees

Comments

@robwise
Copy link
Contributor

robwise commented Oct 27, 2017

Some new stuff has come out and we've bumped our internal project's deps to the point where Yarn is complaining about version ranges defined by RoR:

warning "[email protected]" has unmet peer dependency "babel-runtime@>= 6".
warning "[email protected]" has unmet peer dependency "js-yaml@>= 3.0.0".

This all seems to work fine so we can just loosen the dependency requirements to allow these version ranges.

Also, this happens on every page where RoR is used when using React v16:

Warning: render(): Calling ReactDOM.render() to hydrate server-rendered markup will stop working in React v17. Replace the ReactDOM.render() call with ReactDOM.hydrate() if you want React to attach to the server HTML.
@justin808
Copy link
Member

@Judahmeek Maybe you can fix this and let's ship 10.0.1? or 10.1.0?

@jm96441n
Copy link

So I see this issue is closed, but after updating to the most recent release I'm still getting similar deprecation warnings when running yarn commands:

warning "@rails/webpacker > [email protected]" has unmet peer dependency "caniuse-lite@^1.0.30000697".
warning " > [email protected]" has unmet peer dependency "babel-runtime@>= 6".
warning " > [email protected]" has unmet peer dependency "js-yaml@>= 3.0.0".
warning " > [email protected]" has unmet peer dependency "webpack@^2.2.0 || ^3.0.0".
warning "webpack-dev-server > [email protected]" has unmet peer dependency "webpack@^1.0.0 || ^2.0.0 || ^3.0.0"

@VincentLanglet
Copy link
Contributor

The warning is still here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants