Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parse one frame mpeg-ts video #1015

Merged
merged 11 commits into from
Oct 28, 2022
Merged

fix: Parse one frame mpeg-ts video #1015

merged 11 commits into from
Oct 28, 2022

Conversation

zdanek
Copy link
Contributor

@zdanek zdanek commented Jan 4, 2022 •
edited by joeyparrish
Loading

Closes #1013

@zdanek zdanek mentioned this pull request Jan 4, 2022
Closed
@zdanek zdanek force-pushed the mpegts_one_frame branch 2 times, most recently from 6796807 to 063c21c Compare February 17, 2022 22:44
@zdanek zdanek force-pushed the mpegts_one_frame branch from 063c21c to 9d7606c Compare March 17, 2022 13:38
joeyparrish
joeyparrish requested changes Oct 27, 2022
View reviewed changes
packager/media/codecs/h264_parser.cc Outdated Show resolved Hide resolved
packager/media/formats/mp2t/es_parser_h26x_unittest.cc Outdated Show resolved Hide resolved
packager/media/codecs/h265_parser.cc Outdated Show resolved Hide resolved
packager/media/formats/mp2t/es_parser_h26x.cc Outdated Show resolved Hide resolved
joeyparrish
joeyparrish previously approved these changes Oct 27, 2022
View reviewed changes
@joeyparrish
Copy link
Member

My changes re: ReadBits were wrong, because I thought those classes were using media/base/bit_reader, but in fact, they were not. I'm going to revert those changes and merge this PR.

I'll make a note to merge our multiple BitReader classes later.

joeyparrish
joeyparrish previously approved these changes Oct 28, 2022
View reviewed changes
@joeyparrish joeyparrish merged commit b221aa9 into shaka-project:main Oct 28, 2022
@zdanek
Copy link
Contributor Author

zdanek commented Oct 28, 2022

@joeyparrish thank you for your effort. As for ReadBits, it was 9 months ago but I think I ran into same issue and had to write my own macro.

sr1990 pushed a commit to sr1990/shaka-packager that referenced this pull request Feb 18, 2023
@zdanek @joeyparrish @sr1990
fix: Parse one frame mpeg-ts video (shaka-project#1015)
988e145 
Closes shaka-project#1013

Co-authored-by: Joey Parrish <[email protected]>
sr1990 pushed a commit to sr1990/shaka-packager that referenced this pull request Feb 18, 2023
@zdanek @joeyparrish @sr1990
fix: Parse one frame mpeg-ts video (shaka-project#1015)
7a4fc46 
Closes shaka-project#1013

Co-authored-by: Joey Parrish <[email protected]>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MPEG-TS] Processing one frame videos fail
2 participants
@zdanek @joeyparrish