Optimise posts' images #505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiSG
suggested changes
Feb 27, 2017
There was a problem hiding this comment.
Please don't delete so-called “optional chunks” in PNGs. They include color profiles and gamma correction for macOS, and the decrease in quality is in no way worth the 1% file size gained. This will be even more important with the advent of large color gamut displays.
|
Also, if savings are < 2% (i.e. already previously optimised images), I'm not sure the few bytes saved in delivery are actually worth the binary blobs and the added weight when cloning the repo. Please, in the future, just make sure to enforce image optimisation (and squashing them) in open PRs. |
bonjourmauko
force-pushed
the
optimise-posts-images
branch
from
fde1d29 to
b782fd8
Compare
|
4.74 MB > 3.75 MB (~20%) |
Merged
|
Superseded by #523. |
Merged
This was referenced Apr 20, 2017
sebroussel
pushed a commit
to sebroussel/beta.gouv.fr
that referenced
this pull request
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #502 and #503