Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sampler into CUDA graph #1201

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Move sampler into CUDA graph #1201

merged 14 commits into from
Aug 26, 2024

Conversation

hnyls2002
Copy link
Collaborator

Motivation

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@hnyls2002 hnyls2002 marked this pull request as draft August 25, 2024 01:07
@hnyls2002 hnyls2002 marked this pull request as ready for review August 26, 2024 08:00
@hnyls2002
Copy link
Collaborator Author

For some unknown torch compile bugs, it is fixed in a strange method

if is_torch_compile:
# FIXME: Temporary workaround for unknown bugs in torch.compile
logits.add_(0)

Similar issues:

pytorch/pytorch#129685

https://github.com/pytorch/pytorch/pull/124119/files#diff-809c39aeafb3acc92289f42a63e670a8719d4ce5627d5f88820142d80edf8d2a

@hnyls2002 hnyls2002 requested a review from merrymercy August 26, 2024 08:41
@merrymercy merrymercy merged commit 75ce37f into main Aug 26, 2024
9 checks passed
@merrymercy merrymercy deleted the sampler-cudagraph branch August 26, 2024 14:02
zhyncs added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants