Skip to content

Commit de5c454

Browse files
michael-s-molinasfirke
authored andcommitted
chore: Sets the DRILL_BY feature flag to True by default (apache#26637)
1 parent 2e22083 commit de5c454

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

RESOURCES/FEATURE_FLAGS.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ These features are **finished** but currently being tested. They are usable, but
4343
- CACHE_IMPERSONATION
4444
- CONFIRM_DASHBOARD_DIFF
4545
- DASHBOARD_VIRTUALIZATION
46-
- DRILL_BY
4746
- DRILL_TO_DETAIL
4847
- DYNAMIC_PLUGINS: [(docs)](https://superset.apache.org/docs/installation/running-on-kubernetes)
4948
- ENABLE_JAVASCRIPT_CONTROLS
@@ -68,6 +67,7 @@ These features flags are **safe for production**. They have been tested and will
6867
- DASHBOARD_RBAC [(docs)](https://superset.apache.org/docs/creating-charts-dashboards/first-dashboard#manage-access-to-dashboards)
6968
- DATAPANEL_CLOSED_BY_DEFAULT
7069
- DISABLE_LEGACY_DATASOURCE_EDITOR
70+
- DRILL_BY
7171
- DRUID_JOINS
7272
- EMBEDDABLE_CHARTS
7373
- EMBEDDED_SUPERSET

UPDATING.md

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ assists people when migrating to a new version.
3636
- [26369](https://github.com/apache/superset/issues/26369): Removes the Filter Sets feature including the deprecated `DASHBOARD_NATIVE_FILTERS_SET` feature flag and all related API endpoints. The feature is permanently removed as it was not being actively maintained, it was not widely used, and it was full of bugs. We also considered that if we were to provide a similar feature, it would be better to re-implement it from scratch given the amount of technical debt that the current implementation has. The previous value of the feature flag was `False` and now the feature is permanently removed.
3737
- [26343](https://github.com/apache/superset/issues/26343): Removes the deprecated `ENABLE_EXPLORE_DRAG_AND_DROP` feature flag. The previous value of the feature flag was `True` and now the feature is permanently enabled.
3838
- [26331](https://github.com/apache/superset/issues/26331): Removes the deprecated `DISABLE_DATASET_SOURCE_EDIT` feature flag. The previous value of the feature flag was `False` and now the feature is permanently removed.
39+
- [26637](https://github.com/apache/superset/issues/26637): Sets the `DRILL_BY` feature flag to `True` by default given that the feature has been tested for a while and reached a stable state.
3940

4041
### Potential Downtime
4142

superset/config.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ class D3Format(TypedDict, total=False):
473473
# Enable sharing charts with embedding
474474
"EMBEDDABLE_CHARTS": True,
475475
"DRILL_TO_DETAIL": True,
476-
"DRILL_BY": False,
476+
"DRILL_BY": True,
477477
"DATAPANEL_CLOSED_BY_DEFAULT": False,
478478
"HORIZONTAL_FILTER_BAR": False,
479479
# The feature is off by default, and currently only supported in Presto and Postgres,

0 commit comments

Comments
 (0)