Skip to content

Commit cdd863f

Browse files
rusackassfirke
authored andcommitted
chore(lint/a11y): fixing and locking down jsx-a11y/anchor-is-valid (apache#26820)
1 parent 228f3bc commit cdd863f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

superset-frontend/.eslintrc.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ module.exports = {
116116
'import/no-named-as-default-member': 0,
117117
'import/prefer-default-export': 0,
118118
indent: 0,
119-
'jsx-a11y/anchor-is-valid': 1,
119+
'jsx-a11y/anchor-is-valid': 2,
120120
'jsx-a11y/click-events-have-key-events': 0, // re-enable up for discussion
121121
'jsx-a11y/mouse-events-have-key-events': 0, // re-enable up for discussion
122122
'max-classes-per-file': 0,

superset-frontend/src/SqlLab/components/QueryLimitSelect/index.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ function renderQueryLimit(
7474
{[...new Set(limitDropdown)].map(limit => (
7575
<Menu.Item key={`${limit}`} onClick={() => setQueryLimit(limit)}>
7676
{/* // eslint-disable-line no-use-before-define */}
77-
<a role="button">{convertToNumWithSpaces(limit)}</a>{' '}
77+
{convertToNumWithSpaces(limit)}{' '}
7878
</Menu.Item>
7979
))}
8080
</Menu>

0 commit comments

Comments
 (0)