Fix export crash for models with JSON field #3056
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I experienced a crash when was exporting a model with a JSON field:
Failing lines:
Apparently
bindings[:view]
is nil within export context.Here's a proposed fix for that, I specified an
export_value
for json field.Additionally, another test failed for model querying if JSON field is included, so I suppose it's more practical to return nil instead of raising JSON::ParserError in this case.
Thanks for an awesome product!