Use exact match for 'is' and '=' #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in response to railsadminteam#1819 and is inspired by railsadminteam#2988 This changes less code than railsadminteam#2988, which is currently not passing CI, and preserves postgres checks.
|
Great job 👍 |
|
I was going to suggest doing something like this. Using |
|
When could this be merged? The list view is completly usuable for filtering string fields.. |
|
@mshibuya May we ask what's blocking this pull from being merged? How can we help get it merged? Thanks! |
|
Sorry for delay, thanks! |
|
Could we have a gem cut with this change? |
|
@mshibuya is a release planned anytime soon? This dramatically affects usage for large tables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #1819 and is inspired by #2988
This changes less code than #2988, which is currently not
passing CI, and preserves postgres checks.