Skip to content

Commit 25ae06a

Browse files
committed
Drop Refile support due to inactivity
1 parent 876b364 commit 25ae06a

File tree

10 files changed

+2
-99
lines changed

10 files changed

+2
-99
lines changed

lib/rails_admin/config/fields.rb

-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ def self.register_factory(&block)
8282
require 'rails_admin/config/fields/factories/paperclip'
8383
require 'rails_admin/config/fields/factories/dragonfly'
8484
require 'rails_admin/config/fields/factories/carrierwave'
85-
require 'rails_admin/config/fields/factories/refile'
8685
require 'rails_admin/config/fields/factories/active_storage'
8786
require 'rails_admin/config/fields/factories/shrine'
8887
require 'rails_admin/config/fields/factories/action_text'

lib/rails_admin/config/fields/factories/refile.rb

-25
This file was deleted.

lib/rails_admin/config/fields/types/all.rb

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
require 'rails_admin/config/fields/types/file_upload'
1313
require 'rails_admin/config/fields/types/paperclip'
1414
require 'rails_admin/config/fields/types/carrierwave'
15-
require 'rails_admin/config/fields/types/refile'
1615
require 'rails_admin/config/fields/types/multiple_file_upload'
1716
require 'rails_admin/config/fields/types/multiple_active_storage'
1817
require 'rails_admin/config/fields/types/multiple_carrierwave'

lib/rails_admin/config/fields/types/refile.rb

-27
This file was deleted.

spec/controllers/rails_admin/main_controller_spec.rb

+2-5
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,6 @@ def get(action, params)
329329
field :paperclip_asset do
330330
delete_method :delete_paperclip_asset
331331
end
332-
field :refile_asset if defined?(Refile)
333332
field :active_storage_asset do
334333
delete_method :remove_active_storage_asset
335334
end if defined?(ActiveStorage)
@@ -352,8 +351,7 @@ def get(action, params)
352351
'paperclip_asset' => 'test',
353352
'delete_paperclip_asset' => 'test',
354353
'should_not_be_here' => 'test',
355-
}.merge(defined?(Refile) ? {'refile_asset' => 'test', 'remove_refile_asset' => 'test'} : {}).
356-
merge(defined?(ActiveStorage) ? {'active_storage_asset' => 'test', 'remove_active_storage_asset' => 'test', 'active_storage_assets' => 'test', 'remove_active_storage_assets' => 'test'} : {}).
354+
}.merge(defined?(ActiveStorage) ? {'active_storage_asset' => 'test', 'remove_active_storage_asset' => 'test', 'active_storage_assets' => 'test', 'remove_active_storage_assets' => 'test'} : {}).
357355
merge(defined?(Shrine) ? {'shrine_asset' => 'test', 'remove_shrine_asset' => 'test'} : {}),
358356
)
359357

@@ -368,8 +366,7 @@ def get(action, params)
368366
'retained_dragonfly_asset' => 'test',
369367
'paperclip_asset' => 'test',
370368
'delete_paperclip_asset' => 'test',
371-
}.merge(defined?(Refile) ? {'refile_asset' => 'test', 'remove_refile_asset' => 'test'} : {}).
372-
merge(defined?(ActiveStorage) ? {'active_storage_asset' => 'test', 'remove_active_storage_asset' => 'test', 'active_storage_assets' => 'test', 'remove_active_storage_assets' => 'test'} : {}).
369+
}.merge(defined?(ActiveStorage) ? {'active_storage_asset' => 'test', 'remove_active_storage_asset' => 'test', 'active_storage_assets' => 'test', 'remove_active_storage_assets' => 'test'} : {}).
373370
merge(defined?(Shrine) ? {'shrine_asset' => 'test', 'remove_shrine_asset' => 'test'} : {}))
374371
end
375372

spec/dummy_app/Gemfile

-6
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ group :mongoid do
2727
gem 'kaminari-mongoid'
2828
gem 'mongoid-paperclip', '>= 0.0.8', require: 'mongoid_paperclip'
2929
gem 'carrierwave-mongoid', '>= 0.6.3', require: 'carrierwave/mongoid'
30-
# gem 'refile-mongoid', '>= 0.0.1', platforms: [:ruby_21, :ruby_22]
3130
gem 'shrine-mongoid'
3231
end
3332

@@ -41,11 +40,6 @@ gem 'rails_admin', path: '../../'
4140
gem 'shrine', '~> 2.0'
4241
gem 'shrine-memory'
4342

44-
platforms :mri do
45-
# gem 'refile', '>= 0.5', require: 'refile/rails'
46-
# gem 'refile-mini_magick', '>= 0.1.0'
47-
end
48-
4943
# Gems used only for assets and not required
5044
# in production environments by default.
5145
group :assets do

spec/dummy_app/app/active_record/field_test.rb

-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ class FieldTest < ActiveRecord::Base
1717
mount_uploaders :carrierwave_assets, CarrierwaveUploader
1818
serialize :carrierwave_assets, JSON
1919

20-
attachment :refile_asset if defined?(Refile)
21-
2220
if defined?(ActiveStorage)
2321
has_one_attached :active_storage_asset
2422
attr_accessor :remove_active_storage_asset

spec/dummy_app/app/mongoid/field_test.rb

-9
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,5 @@ class FieldTest
6262
# https://github.com/carrierwaveuploader/carrierwave-mongoid/issues/138
6363
mount_uploader :carrierwave_assets, CarrierwaveUploader
6464

65-
if defined?(Refile)
66-
extend Refile::Mongoid::Attachment
67-
68-
field :refile_asset_filename
69-
field :refile_asset_size
70-
field :refile_asset_content_type
71-
attachment :refile_asset
72-
end
73-
7465
validates :short_text, length: {maximum: 255}
7566
end

spec/rails_admin/config/fields/base_spec.rb

-21
Original file line numberDiff line numberDiff line change
@@ -177,14 +177,6 @@ class CommentReversed < Tableless
177177
end
178178
end
179179

180-
if defined?(Refile)
181-
context 'of a Refile installation' do
182-
it 'is a _id field' do
183-
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :refile_asset }.children_fields).to eq([:refile_asset_id, :refile_asset_filename, :refile_asset_size, :refile_asset_content_type])
184-
end
185-
end
186-
end
187-
188180
if defined?(ActiveStorage)
189181
context 'of a ActiveStorage installation' do
190182
it 'is _attachment and _blob fields' do
@@ -410,12 +402,6 @@ class CommentReversed < Tableless
410402
it 'of carrierwave should find the underlying column on the base table' do
411403
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :carrierwave_asset }.searchable_columns.collect { |c| c[:column] }).to eq(['field_tests.carrierwave_asset'])
412404
end
413-
414-
if defined?(Refile)
415-
it 'of refile should find the underlying column on the base table' do
416-
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :refile_asset }.searchable_columns.collect { |c| c[:column] }).to eq(['field_tests.refile_asset_id'])
417-
end
418-
end
419405
end
420406
end
421407

@@ -447,13 +433,6 @@ class CommentReversed < Tableless
447433
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :carrierwave_asset }.searchable).to eq(:carrierwave_asset)
448434
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :carrierwave_asset }.sortable).to eq(:carrierwave_asset)
449435
end
450-
451-
if defined?(Refile)
452-
it 'of refile should target the first children field' do
453-
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :refile_asset }.searchable).to eq(:refile_asset_id)
454-
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :refile_asset }.sortable).to eq(:refile_asset_id)
455-
end
456-
end
457436
end
458437
end
459438

spec/rails_admin/config/fields/types/file_upload_spec.rb

-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
field :paperclip_asset do
1313
delete_method :delete_paperclip_asset
1414
end
15-
field :refile_asset
1615
field :active_storage_asset do
1716
delete_method :remove_active_storage_asset
1817
end if defined?(ActiveStorage)
@@ -25,7 +24,6 @@
2524
expect(RailsAdmin.config(FieldTest).field(:carrierwave_asset).allowed_methods.collect(&:to_s)).to eq %w(carrierwave_asset remove_carrierwave_asset carrierwave_asset_cache)
2625
expect(RailsAdmin.config(FieldTest).field(:dragonfly_asset).allowed_methods.collect(&:to_s)).to eq %w(dragonfly_asset remove_dragonfly_asset retained_dragonfly_asset)
2726
expect(RailsAdmin.config(FieldTest).field(:paperclip_asset).allowed_methods.collect(&:to_s)).to eq %w(paperclip_asset delete_paperclip_asset)
28-
expect(RailsAdmin.config(FieldTest).field(:refile_asset).allowed_methods.collect(&:to_s)).to eq %w(refile_asset remove_refile_asset) if defined?(Refile)
2927
expect(RailsAdmin.config(FieldTest).field(:active_storage_asset).allowed_methods.collect(&:to_s)).to eq %w(active_storage_asset remove_active_storage_asset) if defined?(ActiveStorage)
3028
expect(RailsAdmin.config(FieldTest).field(:shrine_asset).allowed_methods.collect(&:to_s)).to eq %w(shrine_asset remove_shrine_asset cached_shrine_asset_data) if defined?(Shrine)
3129
end

0 commit comments

Comments
 (0)