Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write e2e tests #31

Closed
kentcdodds opened this issue Jul 9, 2016 · 8 comments · Fixed by #34
Closed

Write e2e tests #31

kentcdodds opened this issue Jul 9, 2016 · 8 comments · Fixed by #34

Comments

@kentcdodds
Copy link
Collaborator

As suggested by @nkbt in #30. Maybe we could use nixt.

@nkbt
Copy link
Collaborator

nkbt commented Jul 9, 2016

I'll take it. Want to try nixt as it looks pretty sick. Hopefully will get some base tests out later today

@kentcdodds
Copy link
Collaborator Author

Sweet. I've never used nixt. Looking forward to what you come up with!

@nkbt
Copy link
Collaborator

nkbt commented Jul 10, 2016

Hm nixt does not seem to work properly for me. Spent a bit of time with it, but no luck yet.

vesln/nixt#16

Maybe I will go with bash then for the moment, or look for some nicer alternative... Not today tho

@kentcdodds
Copy link
Collaborator Author

Cool. See if you can make it work cross-platform so we don't shut out windows users.

@nkbt
Copy link
Collaborator

nkbt commented Jul 10, 2016

That might be a concern, though I expected to run e2e on CI to begin with. Generally I doubt it is possible to do completely cross-platform CLI testing, since shell scripts will be running in background anyway =(.

@kentcdodds
Copy link
Collaborator Author

Makes sense. I think we're OK if it's only running in CI

@nkbt
Copy link
Collaborator

nkbt commented Jul 11, 2016

Since nixt is not really working and writing shell scripts at home on my Windows was not an easy option, I fixed a cli-tester. Not particularly a rocket science thingy...

Had some fun making it work smoothly on all Node versions down to 0.10 (so it is ok with p-s matrix build).

Welcome =)

@kentcdodds
Copy link
Collaborator Author

Cool! Looking forward to seeing the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants