Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug of dynamic configuration module while loading rocketmq host class in version 1.3.x #1416

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Jan 15, 2024

【Fix issue】#1413

[Modification content] The message queue has been modified to prohibit consumption of dynamic configuration. The way to obtain consumers is to obtain them directly through Cache.

[Use case description] No

[Self-test situation] 1. Local static check passed

[Scope of influence] None

@daizhenyu daizhenyu changed the title 修复动态配置模块加载rocketmq宿主类的问题 1.3.x版本修复动态配置模块加载rocketmq宿主类的问题 Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d62423) 42.53% compared to head (f293fd1) 42.51%.

Additional details and impacted files
@@             Coverage Diff              @@
##              1.3.x    #1416      +/-   ##
============================================
- Coverage     42.53%   42.51%   -0.02%     
+ Complexity     3307     3306       -1     
============================================
  Files           831      831              
  Lines         18528    18528              
  Branches       2043     2043              
============================================
- Hits           7880     7878       -2     
- Misses         9661     9662       +1     
- Partials        987      988       +1     
Flag Coverage Δ
unittests 42.51% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit de70319 into sermant-io:1.3.x Jan 15, 2024
4 checks passed
@kkf1 kkf1 changed the title 1.3.x版本修复动态配置模块加载rocketmq宿主类的问题 Fix the bug of dynamic configuration module while loading rocketmq host class in version 1.3.x Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants