Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs in xds flow control #1743

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Jan 21, 2025

What type of PR is this?

Bug

What this PR does / why we need it?

Fix some bugs in xds flow control

How can we reproduce it (as minimally and preci

Which issue(s) this PR fixes?

Fixes #1742

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@hanbingleixue hanbingleixue force-pushed the xds-test branch 2 times, most recently from 2c7c6ad to 8ee7cdf Compare January 23, 2025 07:54
@hanbingleixue hanbingleixue changed the title Fix the issue with the xDS flow control functionality integration test Fix some bugs in xds flow control Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 32.58427% with 60 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...lowcontrol/common/handler/retry/AbstractRetry.java 0.00% 12 Missing ⚠️
...ommon/xds/retry/condition/ResetRetryCondition.java 9.09% 10 Missing ⚠️
...owcontrol/common/xds/retry/RetryConditionType.java 64.00% 8 Missing and 1 partial ⚠️
...xds/retry/condition/ServerErrorRetryCondition.java 10.00% 9 Missing ⚠️
...nt/HttpUrlConnectionResponseStreamInterceptor.java 0.00% 8 Missing ⚠️
.../retry/condition/ConnectFailureRetryCondition.java 20.00% 4 Missing ⚠️
...etry/condition/RetriableHeadersRetryCondition.java 25.00% 3 Missing ⚠️
...lient/OkHttpClientInterceptorChainInterceptor.java 0.00% 3 Missing ⚠️
...ment/service/xds/utils/RdsProtocolTransformer.java 66.66% 1 Missing ⚠️
...ry/condition/ResetBeforeRequestRetryCondition.java 50.00% 1 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 27.69% <32.58%> (-14.79%) 156.00 <0.00> (-25.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...ment/service/xds/utils/CdsProtocolTransformer.java 96.92% <100.00%> (-0.10%) 0.00 <0.00> (ø)
...xds/retry/condition/ClientErrorRetryCondition.java 20.00% <100.00%> (ø) 0.00 <0.00> (?)
...ds/retry/condition/GatewayErrorRetryCondition.java 66.66% <100.00%> (ø) 0.00 <0.00> (?)
.../condition/RetriableStatusCodesRetryCondition.java 40.00% <100.00%> (ø) 0.00 <0.00> (?)
...ment/service/xds/utils/RdsProtocolTransformer.java 40.09% <66.66%> (+0.19%) 0.00 <0.00> (ø)
...ry/condition/ResetBeforeRequestRetryCondition.java 50.00% <50.00%> (ø) 0.00 <0.00> (?)
...etry/condition/RetriableHeadersRetryCondition.java 13.33% <25.00%> (ø) 0.00 <0.00> (?)
...lient/OkHttpClientInterceptorChainInterceptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../retry/condition/ConnectFailureRetryCondition.java 7.14% <20.00%> (ø) 0.00 <0.00> (?)
...nt/HttpUrlConnectionResponseStreamInterceptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 4 more

... and 388 files with indirect coverage changes

@hanbingleixue hanbingleixue force-pushed the xds-test branch 4 times, most recently from 7a09e77 to b97b942 Compare February 7, 2025 01:38
@hanbingleixue hanbingleixue force-pushed the xds-test branch 6 times, most recently from edfa5ef to dfdecf7 Compare February 8, 2025 09:42
@Sherlockhan Sherlockhan merged commit f682ee5 into sermant-io:develop Feb 13, 2025
367 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the issue with the xDS flow control functionality integration test
4 participants