Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@serialport/terminal failing to run #2022

Closed
vidavidorra opened this issue Jan 27, 2020 · 0 comments · Fixed by #2023
Closed

@serialport/terminal failing to run #2022

vidavidorra opened this issue Jan 27, 2020 · 0 comments · Fixed by #2023

Comments

@vidavidorra
Copy link

Summary of Problem

(Please answer all 3)

  • What are you trying to do?
    I'm trying to use serialport-terminal in my terminal (iTerm).
  • What happens?
    After installation npm i -g @serialport/terminal running serialport results in an error.
    serialport-terminal --help
    /usr/local/bin/serialport-terminal: line 1: //: is a directory
    /usr/local/bin/serialport-terminal: line 2: syntax error near unexpected token `('
    /usr/local/bin/serialport-terminal: line 2: `const { Select } = require('enquirer')'
    
  • What should have happened?
    The program should have run the CLI and show me the help information.
  • Fix
    Looks like the issue was introduced in fix: improve the options and output of terminal #1962, where the #!/usr/bin/env node line was commented. Uncommenting this line in the index.js of the installed serialport results in the expected behaviour.
    I'd be happy to submit a PR for this if you want!

Code to Reproduce the Issue

$ npm i -g @serialport/terminal
$ serialport-terminal --help

Versions, Operating System and Hardware

  • serialport@terminal
    serialport-terminal --version
    8.0.6
    
  • Node.js v13.7.0
  • macOS Catalina v10.15.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

0 participants