Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cctalk message timeout #1886

Closed
maxvgi opened this issue Jun 5, 2019 · 2 comments · Fixed by #1887
Closed

Cctalk message timeout #1886

maxvgi opened this issue Jun 5, 2019 · 2 comments · Fixed by #1887

Comments

@maxvgi
Copy link
Contributor

maxvgi commented Jun 5, 2019

💥 Proposal of cctalk parser

What feature you'd like to see

The time between accepted bytes in single cctalk packet cannot exceed 50ms. I want the internal buffer CCTalkParser.array to be reset if I get bytes after delay of more then 50ms.

Motivation

I have cctalk devices in my project. CCTalkParser is used to fetch data packets from serial device. It fetches packet LENGTH out of the header bytes, waits until LENGTH bytes is received, and gives back the whole packet.

And sometimes I get corrupted data on my data line. That is ok, I can check if the packet is correct using packet checksum. If the checksum is invalid, I ignore the packet.

The problems begin when I get corrupted LENGTH byte. The borders of different packets are mixed. And there is no way to fix it, I have to reopen the serial device connection to restore communication with my cctalk devices.

Pitch

I want it to be implemented directly as it is written in CCTalk protocol specification section 11.1.

@reconbot
Copy link
Member

reconbot commented Jun 5, 2019

I’m for it, let’s make this breaking change. Better to be on spec 🙌

If you can, update the docs in the website repo too! And I’ll cut a beta version of the package so you can try it out.

@stale
Copy link

stale bot commented Aug 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week no further activity occurs. Feel free continue the discussion or ask for a never-stale label to keep it open. If this is a support issue, consider sharing it on stack overflow to get more eyes on your problem.

@stale stale bot added the stale-issue label Aug 4, 2019
@stale stale bot closed this as completed Aug 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

2 participants