New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move find_embeddings function logic to abstract class for keras models #1150

Closed

serengil opened this issue Mar 28, 2024 · 1 comment

Labels

Owner

serengil commented Mar 28, 2024

abstract class: https://github.com/serengil/deepface/blob/master/deepface/models/FacialRecognition.py

a base model: https://github.com/serengil/deepface/blob/master/deepface/basemodels/VGGFace.py

we are copying same code for find embeddings to all base models. instead we should copy this to abstract class except SFace and Dlib.

serengil added the enhancement label

serengil mentioned this issue

Feat task 2803 moving find embedding methods to super if not require additional logic #1156

Merged

Owner Author

serengil commented Mar 31, 2024

closed with PR - #1156

serengil closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment