Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting left and right eyes according to the person's perspective instead of observer #1139

Closed
3 tasks done
serengil opened this issue Mar 24, 2024 · 1 comment
Closed
3 tasks done

setting left and right eyes according to the person's perspective instead of observer #1139

serengil opened this issue Mar 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@serengil
Copy link
Owner

serengil commented Mar 24, 2024 •
edited
Loading

Currently, we are returning eye coordinates with respect to the observer's perspective. In other words, left eye value is actually the right eye of the person. We should set these similar to biology!

  • fix left and right eye settings in all detectors
  • add an unit tests to test_extract_faces.py and visual_tests.py checking that left eye is on the right of the right eye
  • update docstrings according to this action
@serengil serengil added the enhancement New feature or request label Mar 24, 2024
This was referenced Mar 24, 2024
Closed
Merged
@serengil
Copy link
Owner Author

Closed with PR - #1140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serengil