Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Megacheck to TravisCI build for smtpapi-go #50

Closed
mbernier opened this issue Oct 29, 2017 · 3 comments · Fixed by #52
Closed

Add Megacheck to TravisCI build for smtpapi-go #50

mbernier opened this issue Oct 29, 2017 · 3 comments · Fixed by #52
Labels
difficulty: easy fix is easy in difficulty

Comments

@mbernier
Copy link

mbernier commented Oct 29, 2017 •
edited
Loading

Issue Summary

Issue sendgrid/sendgrid-go#215, came to be due to a code checking tool called Megacheck

It would be awesome to have this running and breaking Travis builds if it finds something wrong with this library.
@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 29, 2017
This was referenced Oct 29, 2017
Closed
Closed
@mbernier
Copy link
Author

I created a similar Issue in our 2 other Go repos:

@vaskoz
Copy link
Contributor

vaskoz commented Oct 29, 2017

I'll take this one.

@vaskoz vaskoz mentioned this issue Oct 29, 2017
Merged
6 tasks
@vaskoz
Copy link
Contributor

vaskoz commented Oct 29, 2017

Why use a single linter like megacheck when you can use all-of-them with GoMetaLinter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include Gometalinter in Travis CI build vaskoz/smtpapi-go
2 participants
@vaskoz @mbernier