Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting exchange reactions when loading model file #25

Open
mquintin opened this issue Jan 28, 2020 · 1 comment
Open

Sorting exchange reactions when loading model file #25

mquintin opened this issue Jan 28, 2020 · 1 comment

Comments

@mquintin
Copy link
Member

When FBAModel.loadModelFromFile() reads in the line of exchange reaction indexes, it sorts them.

But when the reaction parameter lines ("KM_VALUES", "VMAX_VALUES" etc) are read, they are placed in the same order as in the original file.

So if a model file has the exchange reaction indexes out of order, the kinetic parameters will be mismatched.

(This is a "potential" bug which I haven't actually experienced but my reading of the code for something else makes me suspect it to be the case. Making a note here for myself to write a test case to see if it happens.)

@djbajic
Copy link
Collaborator

djbajic commented Mar 14, 2020

I think this will be more easily sorted out in the toolboxes (py and matlab), any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants