Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Retry network errors #136

Closed
lubird opened this issue Oct 5, 2020 · 1 comment
Closed

[Feature] Retry network errors #136

lubird opened this issue Oct 5, 2020 · 1 comment
Assignees

Comments

@lubird
Copy link
Contributor

lubird commented Oct 5, 2020

The SDK should have a mechanism to cope with failed data uploads because of intermittent network errors or other issues. The retry strategy should be:

  1. Retry network errors (socket timed out, etc.)
  2. Retry server errors (HTTP 5xx)
  3. Do NOT retry client errors (HTTP 4xx) except HTTP 429
@nd4p90x nd4p90x self-assigned this Oct 10, 2020
@nd4p90x
Copy link
Collaborator

nd4p90x commented Oct 19, 2020

This can be marked as "won't fix", the current version supports the retry rules as stated in the issue. There is also a back-off feature with defaults that match current requirements.

@lubird lubird closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants