Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Didn't work at first, but after a few restarts #3

Open
BoneheadFraggle opened this issue Nov 18, 2019 · 2 comments
Open

Didn't work at first, but after a few restarts #3

BoneheadFraggle opened this issue Nov 18, 2019 · 2 comments

Comments

@BoneheadFraggle
Copy link

BoneheadFraggle commented Nov 18, 2019

Edit:
At first it didn't work at all but after a couple of add/remove and a Firefox restart the Favicon Switcher icon finally showed up and then it was quite easy to configure and it works fine.

You see the original favicon flash at load, but then it is changed to the chosen one.

However, when I bookmark the page, the original icon is shown.
Maybe a feature request?

@BoneheadFraggle BoneheadFraggle changed the title No instructions at all Didn't work at first, but after a few restarts Nov 19, 2019
@sefeng211
Copy link
Owner

Sorry for the late reply, somehow I missed the notification.

I think the issue for it didn't work after a couple of add/remove could be related to the how the code interacts with indexedDB, I don't like the current implementation and have some plans to improve it.

Thanks for pointing out the bookmarks, I totally missed it while I was working on it. I'll look into it.

@sefeng211
Copy link
Owner

Looks like at the moment, favicon of bookmarks are not accessible, https://bugzilla.mozilla.org/show_bug.cgi?id=1315616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants