-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public API #3236
Comments
just in case - i can help with adding @internal everywhere with PHP CS Fixer |
I know, thanks. |
Hi, Sebastian. Also, I know that JetBrains also heavily relies on PHPUnit internals to make their integration working. |
JetBrains does not rely on PHPUnit internals, not since the TeamCity test listener was added to PHPUnit. |
Nice thing with public API is that if sth is not marked as part of it, it can always become part of it. Saying that - if we will make public API too narrow, we can always make it wider with any release (minor or even patch) |
I confirm, starting with PHPUnit 5.0 PhpStorm PHPUnit integration relies only on output of TeamCity.php atm |
nice, @sebastianbergmann ! |
In order to define a Backward Compatibility Promise we need to make it explicit which parts of PHPUnit's API are considered to be public.
We should start by adding
@internal
to all classes, interfaces, and traits. Then we need to figure which units of code must be public (and remove@internal
from them) for being able to use PHPUnit.The text was updated successfully, but these errors were encountered: