Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HTTP Basic Authentication #345

Closed
serasihay opened this issue Jul 31, 2021 · 11 comments
Closed

Support for HTTP Basic Authentication #345

serasihay opened this issue Jul 31, 2021 · 11 comments

Comments

@serasihay
Copy link

serasihay commented Jul 31, 2021

Please, consider adding support for HTTP Basic Auth (RFC2617) protected services.

I'm selfhosting a Tiny Tiny RSS service with HTTP Basic Auth; it would be great if FeedMe could detect a "WWW-Authenticate" response header (or have an initial configuration setting in order to be able to send an initial "Authorization" header), to allow entering credentials and accessing such HTTP Basic Auth protected services.

Thanks.

@seazon
Copy link
Owner

seazon commented Aug 10, 2021

@serasihay Actually for TTRSS, FeedMe sets Authorization with value Basic xxx when call auth API, but user need input user name and password instead of base64-user-pass, FeedMe do the encode work.

@serasihay
Copy link
Author

@seazon But then this assumes using the same username/password both for HTTP Basic Auth and TT-RSS login, which is not usually the case, in my opinion.

What I would expect is either an optional additional section in the tt-rss configuration form to fill in the Basic Auth credentials, or a prompt asking for the Basic Auth credentials when a "WWW-Authenticate" response header is received.

@serasihay
Copy link
Author

serasihay commented Sep 22, 2022

Hi @seazon , I'm still very interested in this feature.

Having read again you previous answer, I tried to fill the "Host" field for the "TT-RSS" login form shown in the initial screen with the required username and password for the Basic Auth login using the following pattern:

https://username:[email protected]/tt-rss

But it did not work, FeedMe displayed an "Auth failed" message.

Please, consider again adding proper support for a case like this.

If that helps, you have an example of what I'm asking in the following "extension", available for an old app but that still works.
Here's the form it presents:

tt-rss_http_auth

Here's the source code:
https://github.com/noinnion/newsplus/blob/master/extensions/TtRssExtension/src/com/noinnion/android/newsplus/extension/ttrss/LoginActivity.java

Edit:
Here's the relevant source code from the official tt-rss Android app. I guess it's a more up to date, modern, reference.
https://git.tt-rss.org/fox/tt-rss-android.git/tree/org.fox.ttrss/src/main/java/org/fox/ttrss/ApiCommon.java#n101

@serasihay
Copy link
Author

Hi @seazon , did you find the time to look into this?

@seazon
Copy link
Owner

seazon commented Oct 17, 2024

Thank you for your persistence. I will check it these days.

@seazon
Copy link
Owner

seazon commented Oct 18, 2024

@serasihay can you share your server and provide me an account via email to help test?

@serasihay
Copy link
Author

@seazon Sorry, I'm not sharing my server. You can test basic http authentication (among others) in several public portals, though; like this one:

https://authenticationtest.com/HTTPAuth/
(username: user, password: pass)

@seazon
Copy link
Owner

seazon commented Oct 21, 2024

@serasihay please email to me [email protected], I will send you the test build.

@serasihay
Copy link
Author

Thank you @seazon . Test build received and tested.

The new auth basic capability is working just fine.

I appreciate the time and effort you put into this. :-)

@seazon
Copy link
Owner

seazon commented Oct 26, 2024

@serasihay Great! I will add it in next version.

@seazon
Copy link
Owner

seazon commented Nov 13, 2024

please try 4.3.2

@seazon seazon closed this as completed Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants