Plugin causes Homebridge v1.3.0 beta to crash

[mlamoure]

Hello -

I answered the call for testers for the v1.3.0 beta of homebridge. Updating results in a crash loop for me with the following in the logs:

[1/2/2021, 2:16:23 PM] TypeError: Cannot read property 'omitEventUpdate' of null at Bridge.Accessory.handleCharacteristicChangeEvent (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:1808:100) at Accessory.<anonymous> (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:552:84) at Accessory.emit (events.js:315:20) at Accessory.handleCharacteristicChangeEvent (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:1797:12) at Service.emit (events.js:315:20) at Characteristic.<anonymous> (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Service.ts:669:12) at Characteristic.emit (events.js:315:20) at Object.0.03283219355104894 (/homebridge/node_modules/@miblanchard/homebridge-big-ass-fans/index.js:180:20) at BigAssProperty.<anonymous> (/homebridge/node_modules/@miblanchard/homebridge-big-ass-fans/node_modules/BigAssFansAPI/BigAssApi.js:158:48) at BigAssFan.<anonymous> (/homebridge/node_modules/@miblanchard/homebridge-big-ass-fans/node_modules/BigAssFansAPI/BigAssApi.js:319:36)

[jmissig]

I saw the same issue, thanks for reporting

[Supereg]

The problem is this line

homebridge-bigAssFans/index.js

Lines 180 to 184 in 4807275

	thisChar.emit('change', {
	oldValue:thisChar.value,
	newValue:getOutputMapping(newValue),
	context:null });
	}

.

A plugin MUST NOT fire the change event manually. This is NOT public API.
For such scenarios where you want to push an updated value to HomeKit, use characteristic.updateValue(...).

[mlamoure]

The problem is this line

homebridge-bigAssFans/index.js

Lines 180 to 184 in 4807275

	thisChar.emit('change', {
	oldValue:thisChar.value,
	newValue:getOutputMapping(newValue),
	context:null });
	}

.
A plugin MUST NOT fire the change event manually. This is NOT public API.
For such scenarios where you want to push an updated value to HomeKit, use characteristic.updateValue(...).

Understand the plugin is calling a private event here. Is there a way to mitigate where this does not cause a crash of Homebridge, or has the private event changed since prior to 1.3 and now the crash is because it's being called incorrectly despite never being intended to being called by a plugin in the first place?

Does anyone know if this plugin is actively maintained? I see a number of outstanding PR's for the motion sensor and no recent commits.

[Supereg]

[...] has the private event changed since prior to 1.3 and now the crash is because it's being called incorrectly despite never being intended to being called by a plugin in the first place?

That is exactly what is happening. I see if I may be able to mitigate that.

EDIT: Indeed latest beta should not crash anymore, as of this.

However the plugin MUST still change that, as emitting a change event does not properly persist the value in the characteristic cache.

[mlamoure]

@Supereg confirmed beta 41 does not crash. thank you.