Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove resampling notice #475

Closed
sdatkinson opened this issue May 27, 2024 · 1 comment · Fixed by #476
Closed

[FEATURE] Remove resampling notice #475

sdatkinson opened this issue May 27, 2024 · 1 comment · Fixed by #476
Assignees
Labels
enhancement New feature or request priority:low Low priority issues

Comments

@sdatkinson
Copy link
Owner

With #453, it seems that the resampler is reasonably bug-free. However, the resampling notice generates a lot of concern and questions from people who aren't usually paying attention to the details of the plugins that they're using.

Since it's (IMO) transparent, I'm going to remove it.

This doesn't change the fact that the requested sample rate for any model is accessible by looking at the contents of a model file in a text editor, so if a user is using something a model that you didn't make and don't fully understand(...), they can still always look into it.

@sdatkinson sdatkinson added enhancement New feature or request priority:low Low priority issues labels May 27, 2024
@sdatkinson sdatkinson self-assigned this May 27, 2024
@sdatkinson
Copy link
Owner Author

Do this after #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant