Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Disable Normalization toggle when model has no loudness information #183

Closed
mikeoliphant opened this issue Apr 10, 2023 · 2 comments · Fixed by sdatkinson/NeuralAmpModelerCore#33 or #192
Closed

[FEATURE] Disable Normalization toggle when model has no loudness information #183

mikeoliphant opened this issue Apr 10, 2023 · 2 comments · Fixed by sdatkinson/NeuralAmpModelerCore#33 or #192
Labels
enhancement New feature or request priority:low Low priority issues

Comments

@mikeoliphant
Copy link
Contributor

I think users may be confused that normalization isn't doing anything on models that do not have loudness metadata. Maybe disable the Normalization toggle if the current loaded model has no loudness value?
@mikeoliphant mikeoliphant added enhancement New feature or request priority:low Low priority issues unread This issue is new and hasn't been seen by the maintainers yet urgent:no labels Apr 10, 2023
@sdatkinson
Copy link
Owner

You're absolutely right. In fact, it was so much on my mind to make this issue that when I saw it I thought that I had written it myself!

@sdatkinson sdatkinson removed the unread This issue is new and hasn't been seen by the maintainers yet label Apr 11, 2023
This was referenced Apr 14, 2023
Merged
Merged
@sdatkinson
Copy link
Owner

Solved w/ #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:low Low priority issues
Projects
None yet
Milestone
No milestone
2 participants
@mikeoliphant @sdatkinson