New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pre-warm to overridable method #89

Closed

mikeoliphant opened this issue Oct 16, 2023 · 0 comments · Fixed by #90

Contributor

mikeoliphant commented Oct 16, 2023

The pre-warm code might be leaner in a separate method that gets called after model initialization in get_dsp.

Then WaveNet (and I assume ConvNet) can override it to pre-warm over the receptive field and LSTM can do nothing.

Also, it would make it possible to avoid the default pre-warm behavior and do something else if you bypass get_dsp.

mikeoliphant mentioned this issue

Moved pre-warm to DSP and call it in get_dsp() #90

Merged

sdatkinson closed this as completed in #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment