Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constructors with loudness #86

Closed
sdatkinson opened this issue Oct 15, 2023 · 2 comments · Fixed by #87
Closed

Remove constructors with loudness #86

sdatkinson opened this issue Oct 15, 2023 · 2 comments · Fixed by #87
Assignees
@sdatkinson
Labels
enhancement New feature or request

Comments

@sdatkinson
Copy link
Owner

These result in a lot of copied code. Instead, we can ->SetLoudness() once at the end of get_dsp().
@sdatkinson sdatkinson added the enhancement New feature or request label Oct 15, 2023
@sdatkinson sdatkinson self-assigned this Oct 15, 2023
@mikeoliphant
Copy link
Contributor

👍

This has bugged me since the loudness was added...

@sdatkinson
Copy link
Owner Author

Yeah, apologies for this.

I know what higher-order function I want conceptually, but I'm way behind in my C++ compared to how I know how to do it in other languages 😅 (which is my general excuse for a lot of the kludges in this whole project's code!)

But this'll work better than current, which is at least something 🙂

@sdatkinson sdatkinson mentioned this issue Oct 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdatkinson sdatkinson

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BREAKING] Remove constructors with loudness sdatkinson/NeuralAmpModelerCore
2 participants
@mikeoliphant @sdatkinson