Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to update Cargo.lock.msrv #912

Closed
piodul opened this issue Jan 12, 2024 · 0 comments · Fixed by #913
Closed

Document how to update Cargo.lock.msrv #912

piodul opened this issue Jan 12, 2024 · 0 comments · Fixed by #913
Assignees

Comments

@piodul
Copy link
Collaborator

piodul commented Jan 12, 2024

When dependencies are added or updated in Cargo.toml, it's frequently the case that Cargo.lock.msrv needs to be updated, too. Failing to do so may break the MSRV cargo check with features step in the rust_min workflow with the following message:

Updating crates.io index
error: the lock file /home/runner/work/scylla-rust-driver/scylla-rust-driver/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.
Error: Process completed with exit code 101.

The message doesn't explain what went wrong and how it should be fixed. We need to:

  • Add an instruction to CONTRIBUTING.md on how and when to update Cargo.lock.msrv,
  • Make a short instruction or a reference to CONTRIBUTING.md appear in the output of the MSRV cargo check with features step so that contributors see it when investigating the failure in CI logs.

cc: @Lorak-mmk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants