Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a cycle between helm chart CRD symlinks and the deploy manifests #2043

Closed
Tracked by #424
tnozicka opened this issue Jul 29, 2024 · 0 comments · Fixed by #2044
Closed
Tracked by #424

There is a cycle between helm chart CRD symlinks and the deploy manifests #2043

tnozicka opened this issue Jul 29, 2024 · 0 comments · Fixed by #2044
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@tnozicka
Copy link
Contributor

$ ls -l helm/scylla-operator/crds/
total 16
lrwxrwxrwx. 1 dev dev 69 Feb  8 10:25 00_scylla.scylladb.com_nodeconfigs.yaml -> ../../../pkg/api/scylla/v1alpha1/scylla.scylladb.com_nodeconfigs.yaml
lrwxrwxrwx. 1 dev dev 67 Feb  8 10:25 00_scylla.scylladb.com_scyllaclusters.yaml -> ../../../deploy/operator/00_scylla.scylladb.com_scyllaclusters.yaml
lrwxrwxrwx. 1 dev dev 77 May 22 09:08 00_scylla.scylladb.com_scylladbmonitorings.yaml -> ../../../pkg/api/scylla/v1alpha1/scylla.scylladb.com_scylladbmonitorings.yaml
lrwxrwxrwx. 1 dev dev 74 Feb  8 10:25 00_scylla.scylladb.com_scyllaoperatorconfigs.yaml -> ../../../deploy/operator/00_scylla.scylladb.com_scyllaoperatorconfigs.yaml

./deploy folder is generated from helm manifest and the crds there are symlinks to the canonical localtion in ./pkg/api.

All CRD symlinks should use the canonical CRD location.

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant