Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lightweight transaction metrics (aka CAS) to default dashboard #775

Closed
locker opened this issue Nov 1, 2019 · 3 comments · Fixed by #830
Closed

Add lightweight transaction metrics (aka CAS) to default dashboard #775

locker opened this issue Nov 1, 2019 · 3 comments · Fixed by #830

Comments

@locker
Copy link

locker commented Nov 1, 2019

Here's a list of metrics added for monitoring lightweight transactions performance:

  1. Storage proxy layer.

    scylla_storage_proxy_coordinator_cas_read_latency
    scylla_storage_proxy_coordinator_cas_write_latency
    scylla_storage_proxy_coordinator_cas_read_timeouts
    scylla_storage_proxy_coordinator_cas_write_timeouts
    scylla_storage_proxy_coordinator_cas_read_unavailable
    scylla_storage_proxy_coordinator_cas_write_unavailable
    scylla_storage_proxy_coordinator_cas_read_unfinished_commit
    scylla_storage_proxy_coordinator_cas_write_unfinished_commit
    scylla_storage_proxy_coordinator_cas_write_condition_not_met
    scylla_storage_proxy_coordinator_cas_read_contention
    scylla_storage_proxy_coordinator_cas_write_contention
    

    See commit scylladb/scylladb@c27ab87 for more details.

  2. CQL layer. New tag "conditional" has been added to a few CQL metrics. If set to "yes" for a particular metric, then the metric accounts statements that have IF conditions, otherwise - those that don't. Here's a list of metrics that now have the tag:

    scylla_cql_inserts
    scylla_cql_updates
    scylla_cql_deletes
    scylla_cql_batches
    scylla_cql_statements_in_batches
    

    See commits scylladb/scylladb@f0075ba and scylladb/scylladb@9ea8114 for more details.

@amnonh
Copy link
Collaborator

amnonh commented Dec 2, 2019

@tzach what is your take about this metrics?
I'm not sure about the storage proxy layer, it's good for debugging but for users it's confusing.
Maybe we should add a dashboard for cas in general,

for the cql statements, I can add a filter, that would allow selecting: everything/cas_only/non_cas

@tzach
Copy link
Contributor

tzach commented Dec 2, 2019

CAS can be added to CQL page, these are CQL operations
The overview dashboard can include one summarise metric.

I'm not sure about the storage proxy layer, it's good for debugging but for users it's confusing.

Why? we already present coordinator metrics

@amnonh
Copy link
Collaborator

amnonh commented Dec 2, 2019

But for the users, read/write are not clear, coordinator metrics are better taken from the CQL level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants