Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass adress and port independently to constructor. #109

Closed
clangenb opened this issue Jan 7, 2021 · 1 comment · Fixed by #718
Closed

Pass adress and port independently to constructor. #109

clangenb opened this issue Jan 7, 2021 · 1 comment · Fixed by #718
Assignees
Labels
F7-enhancement Enhances an already existing functionality Q0-trivial

Comments

@clangenb
Copy link
Collaborator

clangenb commented Jan 7, 2021

Change the Api::new(url: String) to Api::new(address: &str, port: &str). Practice shows that this is more convenient as all our CLI`s fetch the url and the port independently, which leads to boilerplate code outside the Api.

Note: &str suffices, as we will assemble the String internally with format!

@haerdib
Copy link
Contributor

haerdib commented Feb 20, 2024

@clangenb api-client now offers the function new_with_port for all rpc clients. Only took 3 years 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F7-enhancement Enhances an already existing functionality Q0-trivial
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants