Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axios needs updated #75

Closed
EsoterikStare opened this issue Apr 24, 2024 · 3 comments
Closed

axios needs updated #75

EsoterikStare opened this issue Apr 24, 2024 · 3 comments

Comments

@EsoterikStare
Copy link

EsoterikStare commented Apr 24, 2024

The current version of axios has a known moderate vulnerability, documented here. It's also grossly out of date, in general.

@AlinaNova21
Copy link
Member

Fixed in v1.16.1, Dependencies overall could probably use bringing up to more modern versions, but also need to be careful of people still running older node for the PS. And I don't have the time to test lately, PRs are welcome though!

@EsoterikStare
Copy link
Author

Thanks!

I'm just starting to wade into Screeps and the library ecosystem around it. I did pull this down and poke at it and updating seems safe, but I'm not 100% sure it wouldn't break others.

It would be nice to at least get everyone up to the lowest node LTS that's still at least in maintenance support. Since active support for v16.x was dropped last year v18.x will be the lowest actively supported LTS for a while longer. But I'm not sure how likely libraries in this community are to be that up-to-date. Seeems like it might be a stretch, based on what I'm seeing so far... =)

It's easy enough to add an engines config to package.json to help people know that if they're below a certain node/npm version, they might have a bad time. Yarn is a little more strict about the version declared there, though...

Let me know what you think about updating deps, running existing tests, and configuring minimum engine versions and I can put together an MR some time soonish, most likely.

@EsoterikStare
Copy link
Author

EsoterikStare commented Apr 28, 2024

Side note: I'm not even using this directly, but through rollup-plugin-screeps-world which is still on v1.11.0, so now I have to go see if I can get them to update. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants