Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for vertical rendering to spec #259

Closed
16 of 19 tasks
tmickel opened this issue Apr 20, 2016 · 2 comments
Closed
16 of 19 tasks

Tracking issue for vertical rendering to spec #259

tmickel opened this issue Apr 20, 2016 · 2 comments
Assignees
Milestone

Comments

@tmickel
Copy link
Contributor

tmickel commented Apr 20, 2016

Match design from #3. This includes:

  • Add one of each of those block types to blocks_vertical so we know what we're up against.
  • Fix actual sizing of blocks (they are larger in spec - to be zoomed down for desktop)
  • Fix corner radii on most blocks
  • Adding a notch to the bottom of statement inputs (bays/holes for blocks)
  • Make notch using Bezier curves (see Notch Curves on the pixel grid #93 for reference - these should be turned on their side for vertical)
  • Fix font sizes to match spec
  • Don't draw holes for shadow blocks in the parent block
  • Draw field chrome for shadow blocks:
    • field_number-type chrome (lots of corner radius)
    • field_text-type chrome (less corner radius)
    • drop-down-type chrome
    • boolean-type chrome
  • Rendering of reporter-type blocks. Blocks with no next, no previous connections, and an output should render as reporters. The shape of the block depends on output type (either boolean-type with angle corners or value-type with rounded corners).
  • Center alignment of text (might get this for free if Horizontal baseline alignment across text, fields, inline values, and external values. google/blockly#333 is implemented in upstream)
  • Fixing the hat block shape to spec
  • Alignment of fields horizontally (LEFT/RIGHT/CENTER)
  • Minimum positioning of second field (see: if, "say" examples), only if there is a previous connection.
  • C-blocks have different minimum width
  • Need to make size of C-block bottoms always match top. I.e., the width of all rows should match the maximum width of a single row...
@tmickel tmickel added this to the Backlog milestone Apr 20, 2016
@tmickel tmickel modified the milestones: July 21, Backlog May 12, 2016
@tmickel
Copy link
Contributor Author

tmickel commented May 25, 2016

400%
r3_vert-block-sketches

@tmickel tmickel self-assigned this May 26, 2016
@tmickel
Copy link
Contributor Author

tmickel commented Jun 8, 2016

Closing and making a couple of new issues.

@tmickel tmickel closed this as completed Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant